httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From b..@locus.apache.org
Subject cvs commit: apache-1.3/src/os/os2 util_os2.c
Date Sat, 04 Nov 2000 07:36:23 GMT
bjh         00/11/03 23:36:22

  Modified:    src/os/os2 util_os2.c
  Log:
  OS/2: Returning an empty string from ap_os_case_canonical_filename() when
  given an invalid file name just makes matters worse as nobody checks the
  return value. In particular, directory_walk() barfs big time when it tries to
  access index.html on a FAT partition (not 8.3 so invalid) as num_dirs can
  become -1 in an unsigned int.....
  
  Revision  Changes    Path
  1.10      +2 -3      apache-1.3/src/os/os2/util_os2.c
  
  Index: util_os2.c
  ===================================================================
  RCS file: /home/cvs/apache-1.3/src/os/os2/util_os2.c,v
  retrieving revision 1.9
  retrieving revision 1.10
  diff -u -r1.9 -r1.10
  --- util_os2.c	2000/09/23 12:06:16	1.9
  +++ util_os2.c	2000/11/04 07:36:21	1.10
  @@ -31,10 +31,9 @@
       if (rc) {
           if ( rc != ERROR_INVALID_NAME ) {
               ap_log_error(APLOG_MARK, APLOG_ERR|APLOG_NOERRNO, NULL, "OS/2 error %d for
file %s", rc, szFile);
  -            return ap_pstrdup(pPool, "");
  -        } else {
  -            return ap_pstrdup(pPool, szFile);
           }
  +
  +        return ap_pstrdup(pPool, szFile);
       }
   
   /* Switch backslashes to forward */
  
  
  

Mime
View raw message