httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apache-2.0/src/main http_connection.c http_core.c http_protocol.c http_request.c util_filter.c
Date Thu, 05 Oct 2000 17:13:20 GMT
On 5 Oct 2000 trawick@locus.apache.org wrote:

> trawick     00/10/05 09:55:18
> 
>   Modified:    src/include http_core.h httpd.h util_filter.h
>                src/main http_connection.c http_core.c http_protocol.c
>                         http_request.c util_filter.c
>   Log:
>   Add a bit of infrastructure which will be needed for input filtering:
>   
>   1) separate filter lists hanging off the r and the c
>   
>      requests start off with the same filter list as the connection
>   
>      the input filter list is not initialized for subrequests
>   
>      internal redirects start off with the same filter list as the
>      connection

Does this make sense?  How do we add input filters for a request?  We
don't even have the request until after the input filters have been
run.  If you are thinking of the request body, that won't work.  Most
browsers send the request body in the same packet as the request headers,
so the body will actually be stored in the conn_rec's bucket_brigade, and
the body will never get to go through the input_filters that were added
after reading the request.

The more I look at our current filtering scheme, the more it looks like
input filters are only valid if they are added before the request is read
from the network.

Ryan

_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------



Mime
View raw message