httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ma...@locus.apache.org
Subject cvs commit: apache-2.0/src/modules/standard mod_userdir.c
Date Mon, 23 Oct 2000 18:14:38 GMT
manoj       00/10/23 11:14:38

  Modified:    src/modules/standard mod_userdir.c
  Log:
  Remove an attempt to fix a race condition. The attempt is not
  successful, the race condition is not particularly important (people
  deleting users in the middle of a request), and the attempt introduces
  more thread-safeness problems. Oh, and I thought I had taken this out
  already. :)
  
  Revision  Changes    Path
  1.20      +0 -6      apache-2.0/src/modules/standard/mod_userdir.c
  
  Index: mod_userdir.c
  ===================================================================
  RCS file: /home/cvs/apache-2.0/src/modules/standard/mod_userdir.c,v
  retrieving revision 1.19
  retrieving revision 1.20
  diff -u -r1.19 -r1.20
  --- mod_userdir.c	2000/10/23 15:30:53	1.19
  +++ mod_userdir.c	2000/10/23 18:14:37	1.20
  @@ -362,12 +362,6 @@
           return NULL;
       }
   
  -    /* XXX - NOT thread-safe! Need APR version of this function */
  -    if ((pw = getpwnam(username)) == NULL) {
  -        /* This should never happen. */
  -        return NULL;
  -    }
  -    
       if ((ugid = apr_palloc(r->pool, sizeof(ap_unix_identity_t *))) == NULL) {
           return NULL;
       }
  
  
  

Mime
View raw message