httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@locus.apache.org
Subject cvs commit: apache-1.3 configure
Date Sat, 07 Oct 2000 15:39:21 GMT
rse         00/10/07 08:39:20

  Modified:    .        configure
  Log:
  Backout revision 1.124 - it was vetoed by me a few weeks ago for the
  following reasons:
  
  1. The patch is inside the Configuration.tmpl parsing loop and this way is
     more or less useless because the distributed Configuration.tmpl file
     doesn't have any *.so names.
  
  2. The example --activate-module=src/modules/xxx/libxxx.so is not
     affected by this patch, because --activate-module and --add-module
     options are implemented a lot later in the configure script.
  
  3. I do not understand what a --activate-module=src/modules/xxx/libxxx.so
     should do. The .[ao] -> .so step is done by configure automatically
     because of --enable-shared, so usually there is never a configured
     src/modules/xxx/libxxx.so path, even if the module exists.
  
  4. The error message talks about ".o|.a|.so|.module", but the actual
     check is for a superset "*.*". This is slightly inconsistent.
  
  Revision  Changes    Path
  1.127     +0 -5      apache-1.3/configure
  
  Index: configure
  ===================================================================
  RCS file: /home/cvs/apache-1.3/configure,v
  retrieving revision 1.126
  retrieving revision 1.127
  diff -u -r1.126 -r1.127
  --- configure	2000/09/28 13:32:28	1.126
  +++ configure	2000/10/07 15:39:19	1.127
  @@ -297,14 +297,9 @@
       module=`echo "$module" |\
               sed -e 's%^.*/\(.*\)$%\1%' \
                   -e 's/\.[oa]$//' \
  -                -e 's/\.so$//' \
                   -e 's/\.module$//' \
                   -e 's/^mod_//' \
                   -e 's/^lib//'`
  -    case $module in
  -     *.*) echo "configure:Error: module name must end in .o|.a|.so|.module" 1>&2
  -          exit 1;;
  -    esac
       eval "module_$module=$add"
       eval "shared_$module=$share"
       modules="${modules}:$module"
  
  
  

Mime
View raw message