httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apache-2.0/src/modules/standard mod_include.c
Date Fri, 15 Sep 2000 21:45:28 GMT
On 15 Sep 2000 trawick@locus.apache.org wrote:

> trawick     00/09/15 14:23:46
> 
>   Modified:    src/modules/standard mod_include.c
>   Log:
>   Handle a tag that appears at the start of a bucket.

This is incorrect.  A split at the start of a bucket should create a zero
length bucket and a bucket with the rest of the data.  If splitting a
bucket at the zero offset returns an error, then we end up with a lot of
special case code throughout the server.

>   Get rid of an endless loop (waiting for dptr2 to become NULL instead of
>   AP_BRIGADE_SENTINEL()).

This change is also incorrect.  If the find_string does not find the
starting sequence, then it will return NULL.  With this change, we will
search for an ending sequence even if we don't have a starting sequence.

Ryan


Mime
View raw message