httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From f...@locus.apache.org
Subject cvs commit: apache-2.0/src/main http_core.c
Date Sun, 10 Sep 2000 05:00:04 GMT
fanf        00/09/09 22:00:04

  Modified:    src/main http_core.c
  Log:
  Use XXX for comments describing inadequacies in the code, as in the rest
  of Apache.
  
  Revision  Changes    Path
  1.117     +6 -6      apache-2.0/src/main/http_core.c
  
  Index: http_core.c
  ===================================================================
  RCS file: /home/cvs/apache-2.0/src/main/http_core.c,v
  retrieving revision 1.116
  retrieving revision 1.117
  diff -u -u -r1.116 -r1.117
  --- http_core.c	2000/09/09 22:35:03	1.116
  +++ http_core.c	2000/09/10 05:00:03	1.117
  @@ -2929,8 +2929,7 @@
   
   	AP_BRIGADE_FOREACH(e, b) {
   	    if (e->type == AP_BUCKET_EOS) {
  -		/* assume it is the last one in the brigade */
  -                /* ### can we chop off the stuff after the EOS? */
  +		/* there shouldn't be anything after the eos */
   		eos = e;
   		break;
   	    }
  @@ -2974,7 +2973,7 @@
                * Insert the chunk header, specifying the number of bytes in
                * the chunk.
                */
  -            /* ### might be nice to have APR_OFF_T_FMT_HEX */
  +            /* XXX might be nice to have APR_OFF_T_FMT_HEX */
               hdr_len = apr_snprintf(chunk_hdr, sizeof(chunk_hdr),
                                      "%qx" CRLF, (apr_uint64_t)bytes);
               e = ap_bucket_create_transient(chunk_hdr, hdr_len);
  @@ -3002,11 +3001,12 @@
            *
            * If there is no EOS bucket, then do nothing.
            *
  -         * ### it would be nice to combine this with the end-of-chunk marker
  -         * ### above, but this is a bit more straight-forward for now.
  +         * XXX: it would be nice to combine this with the end-of-chunk
  +         * marker above, but this is a bit more straight-forward for
  +         * now.
            */
           if (eos != NULL) {
  -            /* ### (2) trailers ... does not yet exist */
  +            /* XXX: (2) trailers ... does not yet exist */
               e = ap_bucket_create_immortal("0" CRLF /* <trailers> */ CRLF, 5);
               AP_BUCKET_INSERT_BEFORE(eos, e);
           }
  
  
  

Mime
View raw message