Mailing-List: contact apache-cvs-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: new-httpd@apache.org
Date: 17 Aug 2000 00:50:34 -0000
Message-ID: <20000817005034.23109.qmail@locus.apache.org>
From: rbb@locus.apache.org
To: apache-2.0-cvs@apache.org
Subject: cvs commit: apache-2.0/src/main util_filter.c

rbb         00/08/16 17:50:34

  Modified:    src/include util_filter.h
               src/main util_filter.c
  Log:
  Make ap_add_filter use a LIFO stack instead of a FIFO queue to add filters
  to the filter stack.  This makes the chunking filter work.  Without this,
  the core_filter is installed in the insert_filters hook, when we get
  to the ap_send_http_headers function, we insert the chunking filter, but
  it has been installed after the core_filter.  This means the chunk_filter
  is never called.
  
  This reverses this.  The core_filter is installed in the insert_filters
  hook, and we put the chunk_filter in during ap_send_http_headers.  This
  time, the chunking filter is installed before the core_filter, and it
  gets called correctly.
  
  Revision  Changes    Path
  1.9       +2 -2      apache-2.0/src/include/util_filter.h
  
  Index: util_filter.h
  ===================================================================
  RCS file: /home/cvs/apache-2.0/src/include/util_filter.h,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- util_filter.h	2000/08/15 02:14:29	1.8
  +++ util_filter.h	2000/08/17 00:50:34	1.9
  @@ -258,8 +258,8 @@
    * list of filters.  Take note of that when adding your filter to the chain.
    */
   /**
  - * Add a filter to the current request.  Filters are added in a FIFO manner.
  - * The first filter added will be the first filter called.
  + * Add a filter to the current request.  Filters are added in a LIFO manner.
  + * The first filter added will be the last filter called.
    * @param name The name of the filter to add
    * @param ctx Any filter specific data to associate with the filter
    * @param r The request to add this filter for.
  
  
  
  1.8       +1 -1      apache-2.0/src/main/util_filter.c
  
  Index: util_filter.c
  ===================================================================
  RCS file: /home/cvs/apache-2.0/src/main/util_filter.c,v
  retrieving revision 1.7
  retrieving revision 1.8
  diff -u -r1.7 -r1.8
  --- util_filter.c	2000/08/16 19:28:27	1.7
  +++ util_filter.c	2000/08/17 00:50:34	1.8
  @@ -91,7 +91,7 @@
   ** corresponds to a different request.
   */
   #define INSERT_BEFORE(f, before_this) ((before_this) == NULL \
  -                                       || (before_this)->ftype > (f)->ftype \
  +                                       || (before_this)->ftype >= (f)->ftype \
                                          || (before_this)->r != (f)->r)