httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject Re: cvs commit: apache-2.0/src/main http_core.c http_protocol.c util_filter.c
Date Wed, 30 Aug 2000 02:09:59 GMT
On 30 Aug 2000 wrote:

> gstein      00/08/29 18:09:15
>   Modified:    src/include util_filter.h
>                src/main http_core.c http_protocol.c util_filter.c
>   Log:
>   reversing the latest commit; it was vetoed a while back.

As outlined in my last mail, this is BS.  The only technical reason for
the veto is that it goes against the design we had, and that it makes the
insert_filters hook backwards.  Insert_filters is also wrong, as I
have been saying for the last week, and a design that has never been
tested is a poor reason for a veto.  I have given strong technical
arguments for why this needs to be a stack, and why insert filters is
incorrect.  I have outlined the correct design, and Roy and Jim have both
spoken up and said it was correct.  This patch started towards the full
design.  As things stand now, we have a broken design with a hack to make
it work.

The current design has us inserting a new filter type everytime we find
one filter that must be added before another filter.  This is not a viable
way to design code that has to be used into the future.

I am leaving town for a while, because I have had a family emergency.  I
will be working on Apache some, but not much.  I hope that somebody comes
up with a workable solution while I am gone, or at least a _valid_
technical reason that this is an invalid patch.


Ryan Bloom               
406 29th St.
San Francisco, CA 94131

View raw message