httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apache-2.0/src/modules/mpm/winnt registry.c
Date Wed, 26 Jul 2000 14:13:47 GMT

I committed this patch, because it was more right than what was
there.  However, IMHO, Apache should probably not be returning APR error
codes unless those errors came from APR.  If Apache wants a safe error
code to represent a problem it encountered, we have error codes available
for applications to use.

Ryan

On 26 Jul 2000 rbb@locus.apache.org wrote:

> rbb         00/07/26 06:45:02
> 
>   Modified:    src/modules/mpm/winnt registry.c
>   Log:
>   The Windows MPM was sometimes returning APR_NOTFOUND when it should
>   have been returning APR_ENOFILE.  This fixes that problem.
>   Submitted by:	Gregory Nicholls <gnicholls@level8.com>
>   Reviewed by:	Ryan Bloom
>   
>   Revision  Changes    Path
>   1.25      +2 -2      apache-2.0/src/modules/mpm/winnt/registry.c
>   
>   Index: registry.c
>   ===================================================================
>   RCS file: /home/cvs/apache-2.0/src/modules/mpm/winnt/registry.c,v
>   retrieving revision 1.24
>   retrieving revision 1.25
>   diff -u -r1.24 -r1.25
>   --- registry.c	2000/07/25 00:58:22	1.24
>   +++ registry.c	2000/07/26 13:45:01	1.25
>   @@ -225,7 +225,7 @@
>    			 &nSize);	/* for size of "value" */
>    
>        if (rv == ERROR_FILE_NOT_FOUND)
>   -        rv = APR_NOTFOUND;
>   +        rv = APR_ENOFILE;
>    
>        RegCloseKey(hKey);
>    
>   @@ -265,7 +265,7 @@
>    			 &nSize);		/* for size of "value" */
>    
>        if (rv == ERROR_FILE_NOT_FOUND) {
>   -        rv = APR_NOTFOUND;
>   +        rv = APR_ENOFILE;
>        }
>        else if (rv != ERROR_SUCCESS) {
>    	return_error(rv);
>   
>   
>   
> 


_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message