httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject Re: cvs commit: apache-2.0/src/lib/apr/file_io/win32 filestat.c
Date Mon, 03 Jul 2000 15:43:04 GMT
On 3 Jul 2000 wrote:

> gstein      00/07/03 05:06:40
>   Modified:    src/lib/apr/include apr_file_io.h
>                src/lib/apr/file_io/os2 filestat.c
>                src/lib/apr/file_io/unix dir.c fileacc.c fileio.h filestat.c
>                         open.c pipe.c
>                src/lib/apr/file_io/win32 filestat.c
>   Log:
>   add ap_finfo_t.device
>   add ap_setfileperms() for setting file permissions (chmod cover).
>       - OS/2 and Win32 currently return APR_ENOTIMPL
>   fix the file perm handling in APR: some conversion between ap_fileperms_t
>       and mode_t was not occurring; adding new conversion function; renamed
>       old conversion func.

Why were these done in one commit?  These are three VERY distinct
patches.  I would also like to understand why the function was
renamed.  This looks like a personal preference as far as the name goes,
which IMHO is not a great reason for the change.  It isn't worth it to
rename it back, but this sure looks like a change for the sake of change.


Ryan Bloom               
406 29th St.
San Francisco, CA 94131

View raw message