Mailing-List: contact apache-cvs-help@apache.org; run by ezmlm
Precedence: bulk
Reply-To: new-httpd@apache.org
Date: 6 Jun 2000 00:57:08 -0000
Message-ID: <20000606005708.3084.qmail@locus.apache.org>
From: trawick@locus.apache.org
To: apache-2.0-cvs@apache.org
Subject: cvs commit: apache-2.0/src/lib/apr/dso/unix dso.c

trawick     00/06/05 17:57:08

  Modified:    src      CHANGES
               src/lib/apr/dso/unix dso.c
  Log:
  Fix bad call to ap_pcalloc() in ap_dso_load(); the bug led to a storage
  overlay as not enough storage was allocated for the ap_dso_handle_t.
  
  Revision  Changes    Path
  1.138     +4 -0      apache-2.0/src/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /home/cvs/apache-2.0/src/CHANGES,v
  retrieving revision 1.137
  retrieving revision 1.138
  diff -u -r1.137 -r1.138
  --- CHANGES	2000/06/06 00:51:19	1.137
  +++ CHANGES	2000/06/06 00:57:07	1.138
  @@ -1,4 +1,8 @@
   Changes with Apache 2.0a5
  +  *) Fix storage overlay when loading dsos.  Symptom: Apache dies at
  +     initialization if ALLOC_DEBUG is defined; no known symptom 
  +     otherwise.  [Jeff Trawick]
  +
     *) Fix typo in configure script when checking for mod_so.  bash
        doesn't seem to have a problem but /bin/sh on Solaris does.
        Symptom: "./configure: test: unknown operator =="
  
  
  
  1.18      +1 -1      apache-2.0/src/lib/apr/dso/unix/dso.c
  
  Index: dso.c
  ===================================================================
  RCS file: /home/cvs/apache-2.0/src/lib/apr/dso/unix/dso.c,v
  retrieving revision 1.17
  retrieving revision 1.18
  diff -u -r1.17 -r1.18
  --- dso.c	2000/06/01 01:01:14	1.17
  +++ dso.c	2000/06/06 00:57:08	1.18
  @@ -82,7 +82,7 @@
   #endif
       }
   
  -    *res_handle = ap_pcalloc(ctx, sizeof(*res_handle));
  +    *res_handle = ap_pcalloc(ctx, sizeof(**res_handle));
       (*res_handle)->handle = (void*)os_handle;
       (*res_handle)->cont = ctx;
       (*res_handle)->errormsg = NULL;