httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apache-2.0/src/modules/standard mod_include.c
Date Sat, 10 Jun 2000 19:07:45 GMT

>   @@ -1196,7 +1196,7 @@
>    #if defined(AP_OFF_T_IS_QUAD)
>                        ap_snprintf(tag, sizeof(tag), "%qd", finfo.size);
>    #else
>   -                    ap_snprintf(tag, sizeof(tag), "%ld", finfo.size);
>   +                    ap_snprintf(tag, sizeof(tag), "%ld", (long)finfo.size);
>    #endif
>                        l = strlen(tag);    /* grrr */
>                        for (x = 0; x < l; x++) {

I dislike this.  Apache in general doesn't use casts, because they mask
real problems.  APR provides an easy MACRO APR_OFF_T_FMT that will fix
this problem correctly without requiring a cast.  I think we should be
using it.

Ryan
_______________________________________________________________________________
Ryan Bloom                        	rbb@apache.org
406 29th St.
San Francisco, CA 94131
-------------------------------------------------------------------------------


Mime
View raw message