httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@covalent.net
Subject Re: cvs commit: apache-2.0/src/modules/mpm/winnt winnt.c
Date Fri, 26 May 2000 20:58:53 GMT
On 27 May 2000 wrowe@locus.apache.org wrote:

> wrowe       00/05/26 23:22:56
> 
>   Modified:    src/main http_main.c
>                src/include http_config.h
>                src/modules/mpm/dexter dexter.c
>                src/modules/mpm/mpmt_beos mpmt_beos.c
>                src/modules/mpm/mpmt_pthread mpmt_pthread.c
>                src/modules/mpm/prefork prefork.c
>                src/modules/mpm/spmt_os2 spmt_os2.c
>                src/modules/mpm/winnt winnt.c
>   Log:
>   
>     Pass the process_rec to the MPM to allow rewriting of the args list.
>     Especially necessary under Win32, or other non-unix front ends where
>     oddball arguments might be required, but without causing a mess in
>     http_main.c.

I dislike this.  You posted last week that you wanted to do this, and you
received back comments asking why this was necessary.  After a thorough
discusssion on new-httpd, it sure sounded like the patch was being
re-written.  Now, the original change has been made.  I personally would
have liked to have seen this patch before it was committed.  I am still
not sure that I like passing the process_req around.  I definately do NOT
like adding another function to the module table.

I am currently -0.5 for this patch, but I need to review it in much more
detail.

Ryan


Mime
View raw message