httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject Re: cvs commit: apache-1.3/src/modules/experimental mod_mmap_static.c
Date Wed, 10 May 2000 18:12:33 GMT
On 10 May 2000 wrote:

> trawick     00/05/10 13:46:52
>   Modified:    src      CHANGES
>                src/modules/experimental mod_mmap_static.c
>   Log:
>   This patch lets an ebcdic box use MMapFile for files that shouldn't be
>   converted from ebcdic->ascii  (.gifs, raw ascii, etc.).  The handler
>   needs to call ap_checkconv() after the Content Type has stabilized, but
>   before the headers are sent.
>   Submitted by:   Greg Ames <>
>   Reviewed by:    Jeff Trawick
>   Revision  Changes    Path
>   1.1538    +4 -0      apache-1.3/src/CHANGES

Why are we committing willy-nilly to the 1.3 tree?  Chuck tried to get 3
+1's for mod_proxy, and he was toldby Roy:

	Basically, my opinion is that no further changes of any kind should
	be made to the 1.3 tree.  If you can get 3 volunteers to do a real
	code review of that branch, fine, but I don't have the time to do
	that and keep up (barely) with the pace of 2.0 development.  So the
	answer is: commit it when you get three +1s from people who have
	actually tested the code.  People who just think its a good idea
	don't count -- I think its a good idea, but that doesn't make it worth
	doing a series of 1.3 releases just to make it work.

I am not adverse to committing to 1.3, because we will most likely have a
1.3.13 release, but I would like this to be a very minor release, that
basically includes the stuff required for Novell and that's it (plus some
possible Windows enhancements).

I would like to move to a review then commit for 1.3, where three
_explicit_ +1's are required for a commit to take place.

I don't know if this means these last three commits should be backed out
or not.


Ryan Bloom               
406 29th St.
San Francisco, CA 94131

View raw message