Return-Path: Delivered-To: apache-cvs-archive@hyperreal.org Received: (qmail 2534 invoked by uid 6000); 23 Jan 2000 17:09:38 -0000 Received: (qmail 2506 invoked by uid 2016); 23 Jan 2000 17:09:34 -0000 Delivered-To: apcore-apache-2.0-cvs@apache.org Received: (qmail 2499 invoked from network); 23 Jan 2000 17:09:33 -0000 Received: from smtp.ntrnet.net (206.66.160.16) by taz.hyperreal.org with SMTP; 23 Jan 2000 17:09:33 -0000 Received: from mail.ntrnet.net (mail.ntrnet.net [206.66.160.4]) by smtp.ntrnet.net (Postfix) with ESMTP id CF2A51F00E; Sun, 23 Jan 2000 12:09:32 -0500 (EST) Received: from shell.ntrnet.net (squid.ntrnet.net [206.66.160.7]) by mail.ntrnet.net (Postfix) with ESMTP id 4728E76806; Sun, 23 Jan 2000 12:09:32 -0500 (EST) Received: (from rbb@localhost) by shell.ntrnet.net (8.8.5/8.8.5) id MAA15661; Sun, 23 Jan 2000 12:09:32 -0500 Date: Sun, 23 Jan 2000 12:09:32 -0500 (EST) From: rbb@apache.org X-Sender: rbb@shell.ntrnet.net To: new-httpd@apache.org Cc: apache-2.0-cvs@apache.org Subject: Re: cvs commit: apache-2.0/src/lib/apr/time/unix timestr.c In-Reply-To: <388AF754.BD50D1AD@algroup.co.uk> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: apache-cvs-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org On Sun, 23 Jan 2000, Ben Laurie wrote: > rbb@apache.org wrote: > > > > > src/lib/apr/include apr_portable.h > > > src/lib/apr/locks/unix crossproc.c locks.h > > > src/lib/apr/time/unix timestr.c > > > Log: > > > Make interprocess mutexes actually choose, fix semaphore mutexes. > > > > What does this mean? > > It means don't force them to be always fcntl, i.e. actually use the > choice instead of overriding it. Okay, I didn't realize we were overriding it. I just didn't understand the comment. > > > > > > Index: apr_portable.h > > > =================================================================== > > > RCS file: /export/home/cvs/apache-2.0/src/lib/apr/include/apr_portable.h,v > > > retrieving revision 1.18 > > > retrieving revision 1.19 > > > diff -u -r1.18 -r1.19 > > > --- apr_portable.h 2000/01/09 20:58:22 1.18 > > > +++ apr_portable.h 2000/01/23 01:13:45 1.19 > > > @@ -81,6 +81,9 @@ > > > #if APR_HAVE_PTHREAD_H > > > #include > > > #endif > > > +#ifdef HAVE_STRUCT_UNION_SEMUN > > > +#include > > > +#endif > > > > This is bad. We cannot use HAVE_ macros in public header files, because > > they aren't namepsace protected. It really doesn't matter if we named > > them ourselves or if autoconf named them for us. Please change this to > > APR_HAVE_STRUCT_UNION_SEMUN. > > Sure, but I couldn't figure out where/how that happens/should happen. Not a problem, I'll do it, and that will serve as an example of how to do this in the future. I won't get to it till tomorrow though.. Ryan Come to the first official Apache Software Foundation Conference!!! _______________________________________________________________________________ Ryan Bloom rbb@ntrnet.net 2121 Stonehenge Dr. Apt #3 Raleigh, NC 27615 Ryan Bloom -- thinker, adventurer, artist, writer, but mostly, friend. -------------------------------------------------------------------------------