httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@apache.org
Subject Re: cvs commit: apache-2.0/src/lib/apr/locks/unix locks.h
Date Mon, 24 Jan 2000 16:01:29 GMT

> >   -#ifdef HAVE_STRUCT_UNION_SEMUN
> >   -#include <sys/sem.h>
> >   -#endif
> > 
> >    #if APR_HAS_THREADS
> >    #if HAVE_PTHREAD_H
> >   @@ -99,7 +96,7 @@
> >    #endif
> >    /* End System Headers */
> > 
> >   -#ifndef HAVE_STRUCT_UNION_SEMUN
> >   +#if !APR_HAVE_UNION_SEMUN && APR_USE_SYSVSEM_SERIALIZE
> >    /* it makes no sense, but this isn't defined on solaris */
> >    union semun {
> >        long val;
> 
> Que? If you don't include sys/sem.h, then this doesn't compile - why did
> you remove it?

If you look about four lines above this,. we include sys/sem.h if it is on
the system.  The problem was we weren't checking for it.  I put the check
into configure.in, so we should be including it.  I just didn't see a need
for sys/sem.h to be included twice.  :-)

> 
> BTW, why are these structures included in the locking structure at all?
> They're essentially constant static structures, but they currently exist
> in each lock.
> 

I have no good answer for this.  I'll look into it though.

Ryan


Come to the first official Apache Software Foundation
Conference!!!   <http://ApacheCon.Com/>

_______________________________________________________________________________
Ryan Bloom                        	rbb@ntrnet.net
2121 Stonehenge Dr. Apt #3
Raleigh, NC 27615		Ryan Bloom -- thinker, adventurer, artist,
				     writer, but mostly, friend.
-------------------------------------------------------------------------------


Mime
View raw message