httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From r..@apache.org
Subject Re: cvs commit: apache-2.0/src/lib/apr/time/unix timestr.c
Date Sun, 23 Jan 2000 17:09:32 GMT
On Sun, 23 Jan 2000, Ben Laurie wrote:

> rbb@apache.org wrote:
> > 
> > >                src/lib/apr/include apr_portable.h
> > >                src/lib/apr/locks/unix crossproc.c locks.h
> > >                src/lib/apr/time/unix timestr.c
> > >   Log:
> > >   Make interprocess mutexes actually choose, fix semaphore mutexes.
> > 
> > What does this mean?
> 
> It means don't force them to be always fcntl, i.e. actually use the
> choice instead of overriding it.

Okay, I didn't realize we were overriding it.  I just didn't understand
the comment.

> 
> > 
> > >   Index: apr_portable.h
> > >   ===================================================================
> > >   RCS file: /export/home/cvs/apache-2.0/src/lib/apr/include/apr_portable.h,v
> > >   retrieving revision 1.18
> > >   retrieving revision 1.19
> > >   diff -u -r1.18 -r1.19
> > >   --- apr_portable.h  2000/01/09 20:58:22     1.18
> > >   +++ apr_portable.h  2000/01/23 01:13:45     1.19
> > >   @@ -81,6 +81,9 @@
> > >    #if APR_HAVE_PTHREAD_H
> > >    #include <pthread.h>
> > >    #endif
> > >   +#ifdef HAVE_STRUCT_UNION_SEMUN
> > >   +#include <sys/sem.h>
> > >   +#endif
> > 
> > This is bad.  We cannot use HAVE_ macros in public header files, because
> > they aren't namepsace protected.  It really doesn't matter if we named
> > them ourselves or if autoconf named them for us.  Please change this to
> > APR_HAVE_STRUCT_UNION_SEMUN.
> 
> Sure, but I couldn't figure out where/how that happens/should happen.

Not a problem, I'll do it, and that will serve as an example of how to do
this in the future.  I won't get to it till tomorrow though..

Ryan


Come to the first official Apache Software Foundation
Conference!!!   <http://ApacheCon.Com/>

_______________________________________________________________________________
Ryan Bloom                        	rbb@ntrnet.net
2121 Stonehenge Dr. Apt #3
Raleigh, NC 27615		Ryan Bloom -- thinker, adventurer, artist,
				     writer, but mostly, friend.
-------------------------------------------------------------------------------


Mime
View raw message