httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ben Laurie <...@algroup.co.uk>
Subject Re: cvs commit: apache-2.0/src/lib/apr/locks/unix locks.h
Date Mon, 24 Jan 2000 19:13:42 GMT
rbb@apache.org wrote:
> 
> > >   -#ifdef HAVE_STRUCT_UNION_SEMUN
> > >   -#include <sys/sem.h>
> > >   -#endif
> > >
> > >    #if APR_HAS_THREADS
> > >    #if HAVE_PTHREAD_H
> > >   @@ -99,7 +96,7 @@
> > >    #endif
> > >    /* End System Headers */
> > >
> > >   -#ifndef HAVE_STRUCT_UNION_SEMUN
> > >   +#if !APR_HAVE_UNION_SEMUN && APR_USE_SYSVSEM_SERIALIZE
> > >    /* it makes no sense, but this isn't defined on solaris */
> > >    union semun {
> > >        long val;
> >
> > Que? If you don't include sys/sem.h, then this doesn't compile - why did
> > you remove it?
> 
> If you look about four lines above this,. we include sys/sem.h if it is on
> the system.  The problem was we weren't checking for it.  I put the check
> into configure.in, so we should be including it.  I just didn't see a need
> for sys/sem.h to be included twice.  :-)

Aha! :-)

In which case, it'd make sense to use HAVE_SYS_SEM_H for the other one,
too.

> > BTW, why are these structures included in the locking structure at all?
> > They're essentially constant static structures, but they currently exist
> > in each lock.
> >
> 
> I have no good answer for this.  I'll look into it though.

:-)

Cheers,

Ben.

--
SECURE HOSTING AT THE BUNKER! http://www.thebunker.net/hosting.htm

http://www.apache-ssl.org/ben.html

Y19100 no-prize winner!
http://www.ntk.net/index.cgi?back=2000/now0121.txt

Mime
View raw message