httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ryan Bloom <...@raleigh.ibm.com>
Subject Re: cvs commit: apache-2.0/src/lib/apr/test htdigest.c testmmap.c
Date Wed, 15 Dec 1999 15:34:18 GMT

>   Index: htdigest.c
>   ===================================================================
>   RCS file: /home/cvs/apache-2.0/src/lib/apr/test/htdigest.c,v
>   retrieving revision 1.9
>   retrieving revision 1.10
>   diff -u -r1.9 -r1.10
>   --- htdigest.c	1999/12/03 16:12:27	1.9
>   +++ htdigest.c	1999/12/15 12:20:40	1.10
>   @@ -66,12 +66,21 @@
>     * by Alexei Kosut, based on htpasswd.c, by Rob McCool
>     */
>    
>   +#include "apr_config.h"
>    #include "apr_lib.h"
>    #include "apr_md5.h"
>   +#ifdef HAVE_SYS_TYPES_H
>    #include <sys/types.h>
>   +#endif
>   +#ifdef HAVE_SYS_SIGNAL_H
>    #include <sys/signal.h>
>   +#endif
>   +#ifdef HAVE_SIGNAL_H
>    #include <signal.h>
>   +#endif
>   +#ifdef HAVE_STDLIB_H
>    #include <stdlib.h>
>   +#endif

None of the test programs can include apr_config.h or use HAVE_FOO_H tests
anymore.  This is because apr_config.h is a private header file, and is
not available to programs using apr.  Test programs should only include
apr.h.  The HAVE_FOO_H macros are by definition internal only, because
they do not protect namespace.  This part of the patch needs to be
backed out, because it does not really test APR's ability to abstract
information.

Ryan
_______________________________________________________________________
Ryan Bloom		rbb@raleigh.ibm.com
4205 S Miami Blvd	
RTP, NC 27709		It's a beautiful sight to see good dancers 
			doing simple steps.  It's a painful sight to
			see beginners doing complicated patterns.	


Mime
View raw message