httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Greg Stein <gst...@lyra.org>
Subject Re: cvs commit: apache-2.0/src/lib/apr/misc/unix start.c
Date Sun, 12 Sep 1999 17:34:17 GMT
rse@hyperreal.org wrote:
> 
> rse         99/09/12 05:12:05
> 
>   Modified:    src/lib/apr configure.in
>                src/lib/apr/include apr_config.h.in
>                src/lib/apr/misc/unix start.c
>   Log:
>   Make sure one can compile a server with MPM prefork if no pthread library is
>   used (even when it exists).  Please be careful, never use a feature test macro
>   for a header to imply that one then can use a function usually defined in this
>   header. You explicitly have to test for the availability of the function.

I believe that is too aggressive. We should be able to rely on a
header's presence to detect that the majority of functions are present.
Sure, there will be a platform here or there where the function doesn't
exist despite the header's presence, but that is the minority case.

I think the position should be "if the header is present, then the
function is" ought to be the default, and when that doesn't work
somewhere, *then* we add the feature test for the function.

Otherwise, we'll be testing every damn function in the C library, and
that is just overkill.

Cheers,
-g

--
Greg Stein, http://www.lyra.org/

Mime
View raw message