Return-Path: Delivered-To: apache-cvs-archive@hyperreal.org Received: (qmail 16771 invoked by uid 6000); 21 Dec 1997 08:18:20 -0000 Received: (qmail 16765 invoked by alias); 21 Dec 1997 08:18:18 -0000 Delivered-To: apachen-cvs@hyperreal.org Received: (qmail 16763 invoked by uid 143); 21 Dec 1997 08:18:17 -0000 Date: 21 Dec 1997 08:18:17 -0000 Message-ID: <19971221081817.16762.qmail@hyperreal.org> From: dgaudet@hyperreal.org To: apachen-cvs@hyperreal.org Subject: cvs commit: apachen/src/main http_protocol.c Sender: apache-cvs-owner@apache.org Precedence: bulk Reply-To: new-httpd@apache.org dgaudet 97/12/21 00:18:17 Modified: . STATUS htdocs/manual/misc known_client_problems.html src CHANGES src/main http_protocol.c Log: Tweak the 257th byte bug... happens at the 256th byte as well. Reviewed by: Jim Jagielski, Brian Behlendorf Revision Changes Path 1.13 +1 -4 apachen/STATUS Index: STATUS =================================================================== RCS file: /export/home/cvs/apachen/STATUS,v retrieving revision 1.12 retrieving revision 1.13 diff -u -r1.12 -r1.13 --- STATUS 1997/12/21 05:31:42 1.12 +++ STATUS 1997/12/21 08:18:12 1.13 @@ -45,6 +45,7 @@ * Igor Tatarinov's [PATCH] usage patch (-V) * Dean's [PATCH] child_timeout not correctly defined * Mark Bixby's [PORT] MPE porting patch + * Dean's [PATCH] Re: problem with a .gif and v2.1.4 Available: @@ -79,10 +80,6 @@ * Martin's [PATCH] 36kB: Make apache compile & run on an EBCDIC mainframe <19971217184646.62136@deejai.mch.sni.de> Status: Martin +1, Dean +1 - - * Dean's [PATCH] Re: problem with a .gif and v2.1.4 - - Status: Dean +1, Jim +1, Brian +1 * Martin's [PATCH] Gimme a break! <19971217170852.51979@deejai.mch.sni.de> 1.4 +2 -2 apachen/htdocs/manual/misc/known_client_problems.html Index: known_client_problems.html =================================================================== RCS file: /export/home/cvs/apachen/htdocs/manual/misc/known_client_problems.html,v retrieving revision 1.3 retrieving revision 1.4 diff -u -r1.3 -r1.4 --- known_client_problems.html 1997/07/22 08:51:02 1.3 +++ known_client_problems.html 1997/12/21 08:18:13 1.4 @@ -129,11 +129,11 @@

All versions of Navigator from 2.0 through 4.0b2 (and possibly later) have a problem if the trailing CRLF of the response header starts at -the 256th or 257th byte of the response. A BrowserMatch for this would +offset 256, 257 or 258 of the response. A BrowserMatch for this would match on nearly every hit, so the workaround is enabled automatically on all responses. The workaround is to detect when this condition would occur in a response and add extra padding to the header to push the -trailing CRLF past the 257th byte of the response. +trailing CRLF past offset 258 of the response.

Multipart responses and Quoted Boundary Strings

1.535 +5 -1 apachen/src/CHANGES Index: CHANGES =================================================================== RCS file: /export/home/cvs/apachen/src/CHANGES,v retrieving revision 1.534 retrieving revision 1.535 diff -u -r1.534 -r1.535 --- CHANGES 1997/12/20 23:51:03 1.534 +++ CHANGES 1997/12/21 08:18:14 1.535 @@ -1,5 +1,9 @@ Changes with Apache 1.3b4 - + + *) It appears the "257th byte" bug (see + htdocs/manual/misc/known_client_problems.html#257th-byte) can happen + at the 256th byte as well. Fixed. [Dean Gaudet] + *) Fix mod_mime_magic under OS/2, no support for block devices. [Brian Havard] 1.171 +2 -2 apachen/src/main/http_protocol.c Index: http_protocol.c =================================================================== RCS file: /export/home/cvs/apachen/src/main/http_protocol.c,v retrieving revision 1.170 retrieving revision 1.171 diff -u -r1.170 -r1.171 --- http_protocol.c 1997/12/20 23:44:30 1.170 +++ http_protocol.c 1997/12/21 08:18:16 1.171 @@ -1092,7 +1092,7 @@ /* Navigator versions 2.x, 3.x and 4.0 betas up to and including 4.0b2 * have a header parsing bug. If the terminating \r\n occur starting - * at the 256th or 257th byte of output then it will not properly parse + * at offset 256, 257 or 258 of output then it will not properly parse * the headers. Curiously it doesn't exhibit this problem at 512, 513. * We are guessing that this is because their initial read of a new request * uses a 256 byte buffer, and subsequent reads use a larger buffer. @@ -1112,7 +1112,7 @@ long int bs; bgetopt(client, BO_BYTECT, &bs); - if (bs == 256 || bs == 257) + if (bs >= 255 && bs <= 257) bputs("X-Pad: avoid browser bug\015\012", client); bputs("\015\012", client); /* Send the terminating empty line */