httpd-cvs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian Behlendorf <br...@organic.com>
Subject Re: cvs commit: apache/support logresolve.c Makefile
Date Thu, 08 Aug 1996 02:35:40 GMT
On 7 Aug 1996, Paul Richards wrote:
> Brian Behlendorf <brian@hyperreal.com> writes:
> 
> >   + #ifdef __EMX__
> >   + /* Need this include before any others under OS/2 */
> >   + #include <sys/types.h>
> >   + #endif
> >   + 
> 
> This should  be done for all OS's. Most OS's get away with it because
> header files that need other header files include them and the files
> are made idempotent with #ifdef tricks. Special casing OS/2 just adds
> more #ifdef spaghetti.
> 
> The bit of the BSD style guide that said system files should be
> included first was most likely related to this.

Sounds right to me.  I'll make the change.

	Brian

--=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
brian@organic.com  www.apache.org  hyperreal.com  http://www.organic.com/JOBS


Mime
View raw message