From owner-apache-cvs@hyperreal.com Sat Apr 20 05:00:17 1996 Received: by taz.hyperreal.com (8.6.12/8.6.5) id FAA14129; Sat, 20 Apr 1996 05:00:17 -0700 Received: by taz.hyperreal.com (8.6.12/8.6.5) id FAA14122; Sat, 20 Apr 1996 05:00:15 -0700 Date: Sat, 20 Apr 1996 05:00:15 -0700 From: Ben Laurie Message-Id: <199604201200.FAA14122@taz.hyperreal.com> To: apache-cvs@hyperreal.com Subject: cvs commit: apache/src mod_digest.c Sender: owner-apache-cvs@apache.org Precedence: bulk ben 96/04/20 05:00:15 Modified: src mod_digest.c Log: Correct premature strlen() of possibly NULL pointer. Submitted by: Sean Welch Revision Changes Path 1.4 +3 -1 apache/src/mod_digest.c Index: mod_digest.c =================================================================== RCS file: /export/home/cvs/apache/src/mod_digest.c,v retrieving revision 1.3 retrieving revision 1.4 diff -C3 -r1.3 -r1.4 *** mod_digest.c 1996/03/26 19:05:24 1.3 --- mod_digest.c 1996/04/20 12:00:14 1.4 *************** *** 121,127 **** int get_digest_rec(request_rec *r, digest_header_rec *response) { char *auth_line = table_get(r->headers_in, "Authorization"); ! int l = strlen(auth_line); int s = 0, vk = 0, vv = 0; char *t, *key, *value; --- 121,127 ---- int get_digest_rec(request_rec *r, digest_header_rec *response) { char *auth_line = table_get(r->headers_in, "Authorization"); ! int l; int s = 0, vk = 0, vv = 0; char *t, *key, *value; *************** *** 144,149 **** --- 144,151 ---- note_digest_auth_failure (r); return AUTH_REQUIRED; } + + l = strlen(auth_line); key=palloc(r->pool,l); value=palloc(r->pool,l);