httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 60487] Core dumps in mpm_event during graceful restart
Date Thu, 16 Feb 2017 21:57:07 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=60487

--- Comment #9 from Eric Covener <covener@gmail.com> ---
(In reply to Eric Covener from comment #8)
> (In reply to Yann Ylavic from comment #7)
> > (In reply to Eric Covener from comment #2)
> > > 
> > > Maybe a good sanity check would be to look
> > > for mpm_state == AP_MPMQ_STARTING when retained == NULL and no-op'ing it
> > > altogether.  An even safer option might be to only handle the graceful
> > > flavors w/ the new block, to avoid the chance a hard stop or hard restart is
> > > ignored if we're missing something?
> > 
> > I think we should avoid touching anything scoped/static to the mpm module
> > (dso) in a signal handler, otherwise any signal delivered while the module
> > is unloaded might raise the fault.
> > 
> > That is: mpm_state, shutdown_pending, restart_pending and retained.
> > 
> > How about allocating them (in a struct) from ap_pglobal?
> 
> I assumed we wouldn't be able to enter the static functions that touch the
> static variables, but I guess better safe than sorry.

although safer still might be ignoring those signals until an MPM can come back
up?

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message