httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 59829] Detect HTTPS marker from reverse proxy
Date Thu, 01 Dec 2016 19:51:05 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=59829

--- Comment #3 from coladict@gmail.com ---
This part worries me about your proposal

r->server->server_scheme = config->secure_header_value;

This is not guaranteed to always be "http" or "https". That variable is set by
the user, because you can't guarantee how their existing reverse proxy server
reports it. I think it should be changed just to:

r->server->server_scheme = "https";

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message