httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject [Bug 59829] Detect HTTPS marker from reverse proxy
Date Mon, 12 Dec 2016 09:22:27 GMT

Peter H. <> changed:

           What    |Removed                     |Added
  Attachment #34496|0                           |1
        is obsolete|                            |
  Attachment #34507|0                           |1
        is obsolete|                            |

--- Comment #8 from Peter H. <> ---
Created attachment 34518
using apr_itoa for integer conversion, removed comment setting

Changed two things compared to previous patch:

The note "remoteip-proxy-ip-list" in the request-table is meant to be used by
mod_log_config to log the proxy forwarding the request. I removed the comment
at this line.

Instead of using snprintf for converting the integer value to a character array
you can use apr_itoa. Thus the definition of a buffer at the data structure for
remoteip_config_t is not necessary. There is no impact on complexity for
allocating and deallocating the memory on destruction of the request pool,
because the memory isn't really deallocated, but added to a list of free memory
managed by the apache core.
Unfortunately the apache documentation doesn't go that much into detail
regarding memory management.

You are receiving this mail because:
You are the assignee for the bug.
To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message