httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 21935] r->parsed_uri->query isn't updated after execution of mod_rewrite
Date Wed, 10 Aug 2016 17:10:34 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=21935

--- Comment #6 from Yann Ylavic <ylavic.dev@gmail.com> ---
Created attachment 34120
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34120&action=edit
Use the current path and query-string for the entity key

In latest versions, the key for the current entity (request) is computed early
in the (quick)handler, and reused later when referring to the entity so that
rewrites on the path or the query-string don't break things.

The possible issue is that this key is computed based on the original
query-string (the path is the one when the handler is called already).
This works when mod_cache is configured with "CacheQuickHandler on" (the
default) since no rewrite should happen before any quick_handler, but not when
CacheQuickHandler is off (and the admin wants its changes to be taken into
account for caching).

This patch tries to use r->uri and r->args where appropriate (instead of
immutable r->parsed_uri.path and r->parsed_uri.query) such that the entity key
is computed accordingly.
It works with both trunk and 2.4.x.

Could you please try it?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message