httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 58929] coredump when sending illegal CONNECT request
Date Fri, 29 Jan 2016 10:20:04 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=58929

--- Comment #4 from Frank Meier <frank.meier@ergon.ch> ---
I like the patch, it solves the bug where it was introduced.

I'd additionally suggest to fix the ap_add_cgi_vars() function, to make it more
robust. See patch bellow:


--- a/server/util_script.c
+++ b/server/util_script.c
@@ -379,7 +379,7 @@ AP_DECLARE(void) ap_add_cgi_vars(request_rec *r)
      * come with the script URI in the include command.  Ugh.
      */

-    if (!strcmp(r->protocol, "INCLUDED")) {
+    if ( r->protocol && !strcmp(r->protocol, "INCLUDED")) {
         apr_table_setn(e, "SCRIPT_NAME", r->uri);
         if (r->path_info && *r->path_info) {
             apr_table_setn(e, "PATH_INFO", r->path_info);

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message