httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 46412] make_child return value not checked
Date Mon, 13 Apr 2015 16:50:50 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=46412

thekevinday@gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #23036|0                           |1
        is obsolete|                            |

--- Comment #2 from thekevinday@gmail.com ---
Created attachment 32645
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=32645&action=edit
checking return value of make_child()

make_child()'s return value is still not checked even with httpd-2.4.

This also affects all these three workers:
- event
- prefork
- worker

Looking at httpd-2.4, the return value for make_child() appears to return 0
when there is no failure.

I suggest:
    if (make_child(ap_server_conf, child_slot) >= 0) {
       --remaining_children_to_start;
    }

Instead of:
    if (make_child(ap_server_conf, child_slot) > 0) {
       --remaining_children_to_start;
    }

because in the case of a return value of 0, the remaining_children_to_start
should still be decremented.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message