httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 57553] mod_ssl_ct causes connection failures when configured 'empty'
Date Fri, 20 Feb 2015 02:10:07 GMT
https://bz.apache.org/bugzilla/show_bug.cgi?id=57553

--- Comment #2 from Tom Ritter <tom@ritter.vg> ---
Okay, I tracked it down and figured it out.  look_for_server_certs() is called
multiple times for multiple VHOSTs, but is not set up for that.  Specifically,
sconf->server_cert_info = apr_array_make(p, 2, sizeof(ct_server_cert_info));
overwrites the initial allocation.  (Leaking memory in the process.)

I don't know what the 'correct' fix for this, you'd probably allocate one slot
and then grow the array on subsequent calls, but I don't know how to do that. I
did a simple fix  by just putting a if(!sconf->server_cert_info) in front of it
and making it allocate 4 slots instead of 2.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message