httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 48388] mod proxy disabling workers after a single error
Date Tue, 06 Jan 2015 11:37:40 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=48388

--- Comment #14 from Yann Ylavic <ylavic.dev@gmail.com> ---
(In reply to Ruediger Pluem from comment #13)
> (In reply to Yann Ylavic from comment #10)
> > Created attachment 32341 [details]
> > Don't put normal (non balancer-member) workers in error (trunk/2.4.x)
> > 
> > This patch should prevent httpd from putting workers which are *not*
> > load-balancer members in error state, since we don't want the retry timeout
> > to be applied when there is no alternative to connect to.
> 
> -1 as this being hardcoded. This can be already done with retry=0. We may
> discuss to set retry=0 as a default value in this case if not set
> explicitly. It may make sense to put even a single backend in error state
> for some time to give the backend some time to recover without new requests
> sent to it and have them blocked at the reverse proxy layer.

Nothing is hardcoded here, the default being still status=-I for
balancer-members, but changed to status=+I for the standalone workers (but it
can still be opt-out).
This is indeed debatable, the backend's time-to-recover argument is right/real,
but there is no status=+I vs retry=0 here, both would change the default
behaviour (is that acceptable?).

The only difference (I see) between status=+I and retry=0 is the logging of the
worker's error/recovery states (in addition to the protocol/socket error).
I think this logging should be done only for status=-I workers (hence +I should
ignore any error, not only those from connect()/handshake, eg.
failon{status,timeout} or 500/503...).
This is at least what I did (try to) implement in this patch, so that users
with simple workers don't bother (including logs) with recovery period if they
configured so (or by default, if acceptable).

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message