httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject [Bug 41867] <DirectoryMatch> Matches Files
Date Thu, 22 Jan 2015 00:03:20 GMT

William A. Rowe Jr. <> changed:

           What    |Removed                     |Added
             Status|ASSIGNED                    |NEW

--- Comment #21 from William A. Rowe Jr. <> ---
Thanks again imacat for the report.  Your observations absolutely have merit
and need to be addressed.  I've reverted the patch with the following notes,
reproducing here for completeness...

Revert r4635428 corresponding to PR41867.

The code reverted attempted to restrict comparisons of the r->filename
to given DirectoryMatch blocks.

r->filename was already a non-directory entity at this point, because we
have already fallen out of the } while (thisinfo.filetype == APR_DIR);
block above.

The addition of r->d_is_directory was redundant.  That is what is always
returned by ap_get_core_module_config(r->per_dir_config).

Note modifying dir_config required an MMN major bump as this commit could
have realigned the offset of refs (had it been added to the end, this
would correspond to an mmn minor bump) and other fields packed into the
same bytes (this is undefined). Bump on revert to prevent unexpected crashes.

You are receiving this mail because:
You are the assignee for the bug.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message