httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 56858] non-terminated buffer passed to ap_log_rerror
Date Fri, 15 Aug 2014 19:02:23 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=56858

--- Comment #1 from Jeff Trawick <trawick@apache.org> ---
This for the report.  Here is a simpler fix:

Index: modules/proxy/mod_proxy_fcgi.c
===================================================================
--- modules/proxy/mod_proxy_fcgi.c    (revision 1617253)
+++ modules/proxy/mod_proxy_fcgi.c    (working copy)
@@ -665,7 +665,7 @@
                 /* TODO: Should probably clean up this logging a bit... */
                 if (clen) {
                     ap_log_rerror(APLOG_MARK, APLOG_ERR, 0, r, APLOGNO(01071)
-                                  "Got error '%s'", iobuf);
+                                  "Got error '%.*s'", (int)readbuflen, iobuf);
                 }

                 if (clen > readbuflen) {

I'll commit that when I get a chance to test...

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message