httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 55910] Continuation lines are broken during buffer resize
Date Sun, 17 Aug 2014 17:18:49 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=55910

Manuel Mausz <manuel-asf@mausz.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #31133|0                           |1
        is obsolete|                            |

--- Comment #3 from Manuel Mausz <manuel-asf@mausz.at> ---
Created attachment 31923
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=31923&action=edit
continuation-lines-v2.patch

Since there doesn't seem to be much interest in fixing this edge case of the
parser, I decided to rewrite the patch to be more sane. The outcome is
attached.

Instead of adding a grown-flag to indicate we can look behind the first byte,
the function now expects the whole buffer, it's actual size and the current
offset to write to.

Additional I've fixed a bug in the "getch"-branch that also happens during
buffer resize. The APR_ENOSPC check is *before* storing the current character.
So this one gets lost.

I've checked both branches against all our webservers and there were no parsing
errors.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message