Return-Path: X-Original-To: apmail-httpd-bugs-archive@www.apache.org Delivered-To: apmail-httpd-bugs-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C18FBE297 for ; Sun, 10 Feb 2013 17:20:57 +0000 (UTC) Received: (qmail 79011 invoked by uid 500); 10 Feb 2013 17:20:57 -0000 Delivered-To: apmail-httpd-bugs-archive@httpd.apache.org Received: (qmail 78934 invoked by uid 500); 10 Feb 2013 17:20:56 -0000 Mailing-List: contact bugs-help@httpd.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: Reply-To: "Apache HTTPD Bugs Notification List" List-Id: Delivered-To: mailing list bugs@httpd.apache.org Received: (qmail 78927 invoked by uid 99); 10 Feb 2013 17:20:56 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Feb 2013 17:20:56 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.115] (HELO eir.zones.apache.org) (140.211.11.115) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 10 Feb 2013 17:20:55 +0000 Received: by eir.zones.apache.org (Postfix, from userid 80) id 4FBD14C17; Sun, 10 Feb 2013 17:20:34 +0000 (UTC) From: bugzilla@apache.org To: bugs@httpd.apache.org Subject: [Bug 54543] New: Compile regex only when need Date: Sun, 10 Feb 2013 17:20:33 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Apache httpd-2 X-Bugzilla-Component: mod_rewrite X-Bugzilla-Keywords: X-Bugzilla-Severity: enhancement X-Bugzilla-Who: david@ols.es X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: bugs@httpd.apache.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter classification Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://issues.apache.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/bugzilla/show_bug.cgi?id=54543 Bug ID: 54543 Summary: Compile regex only when need Product: Apache httpd-2 Version: 2.4.3 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P2 Component: mod_rewrite Assignee: bugs@httpd.apache.org Reporter: david@ols.es Classification: Unclassified Regular expressions are compiled (with ap_pregcomp) when parsing the configuration regardless if they will end being used or not. If it makes sense i can submit a patch that will not compile the regex and substitute the calls to ap_regexec to calls to a function that will compile the regex if x->regex is null so only really need regex will be compiled I think this could improve performance a bit, specially when using END/L flags and when the request matches the first rules, and will not affect performance in other cases. Anyway i could implement this as an option if you guys think that it will be better that way. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org For additional commands, e-mail: bugs-help@httpd.apache.org