httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 54384] New: Improve a confusing log message related to LimitRequestLine
Date Tue, 08 Jan 2013 09:40:17 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=54384

            Bug ID: 54384
           Summary: Improve a confusing log message related to
                    LimitRequestLine
           Product: Apache httpd-2
           Version: 2.4.3
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: major
          Priority: P2
         Component: Core
          Assignee: bugs@httpd.apache.org
          Reporter: jackie.qq.zhang@gmail.com
    Classification: Unclassified

Created attachment 29828
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29828&action=edit
An improved log message patch to make the diagnosis easier

Hi, all,

Is it possible to change the following log message to be more accurate and
explicit that links to the configuration directive? (see the patch attached)

"AH00565: request failed: URI too long (longer than xxxx)"

Currently, it's kind of confusing without reading the code. I even do not know
what the "URI" refers to when saw the log message: I didn't know whether it's a
problem on the server side or client side.

Having read the code, I know this's because and only because the client's HTTP
request-line exceeds the server's "LimitRequestLine" setting.

Compared with "LimitRequestLine", the log message of "LimitRequestFieldsize" is
very very clear:

"AH00561: Request header exceeds LimitRequestFieldSize"

Moreover, the current message is not acurrate because request-line also
consists of the HTTP method and protocol version besides URI.

I wonder whether we can have the same style of logging, which is implemented in
the patch. 

Notice that the logging is at the place where "This is only going to happen if
it exceeds the configured limit for a request-line", so the patch is valid.
(You can search "HTTP_REQUEST_URI_TOO_LARGE" in the code to verify it) 

Thanks,
Jackie

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message