httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 54145] Poor error handling in dav_method_put()
Date Wed, 14 Nov 2012 22:56:50 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=54145

--- Comment #1 from Ben Reser <ben@reser.org> ---
Created attachment 29598
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29598&action=edit
Improves error handling in dav_method_put()

The attached patch resolves the problems described on this bug.

1) The error message for the ap_get_brigade() is changed to "An error occurred
while reading the request body" and the later apr_bucket_read() calls error
message is changed to be unique by adding the phrase "from the bucket."  Since
the  apr_bucket_read() error is highly unlikely the more technical and internal
oriented error message is appropriate.

2) A new function dav_join_error() is created that allows one error stack to be
added to the end of another.  This is used in non-looping portions of
dav_method_put to preserve both the mod_dav error and the DAV providers error.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message