httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 53837] New: Code clean up (various)
Date Thu, 06 Sep 2012 20:17:56 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=53837

          Priority: P2
            Bug ID: 53837
          Assignee: bugs@httpd.apache.org
           Summary: Code clean up (various)
          Severity: normal
    Classification: Unclassified
                OS: All
          Reporter: christophe.jaillet@wanadoo.fr
          Hardware: All
            Status: NEW
           Version: 2.5-HEAD
         Component: All
           Product: Apache httpd-2

Created attachment 29337
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=29337&action=edit
Proposed patch

Hi,

here is a set of small obvious clean up.

* No need to test for NULL before calling apr_pstrdup
     server/error_bucket.c
     modules/generators/mod_autoindex.c
     modules/lua/lua_vmprep.c
     modules/ssl/ssl_engine_vars.c


* s/;;/;/
     modules/generators/mod_autoindex.c
     modules/dav/main/util.c
     server/provider.c
     modules/examples/mod_example_hooks.c
     modules/loggers/mod_log_config.c
     modules/session/mod_session.c

* use apr_table_setn when strings are constant or already pool allocated
     modules/examples/mod_example_hooks.c

* simplify using 'apr_hash_this_key_len'
     modules/session/mod_session_crypto.c

* no need to apr_calloc when the memory is fully written just after allocation
     modules/ldap/util_ldap.c

* only compute new length if something has been added to the string
     server/apreq_cookie.c


Best regards,
CJ

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message