httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 52120] mod_cache edge case: uncacheable 304 sends cached body, but not cached headers
Date Thu, 02 Aug 2012 13:14:06 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=52120

Roy Badami <roy@gnomon.org.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
           Hardware|PC                          |All
            Version|2.3.14-beta                 |2.2.22
         Resolution|FIXED                       |---
                 OS|Mac OS X 10.5               |All

--- Comment #2 from Roy Badami <roy@gnomon.org.uk> ---
As far as I can see, this fix was never merged into the 2.2.x branch and
although the circumstances to trigger this bug are very specific, its effects
can be quite nasty when it manifests.

The failure to merge headers means that entity header fields (which are not
included in a 304 response) are not sent to the client.  In the case of an
object with a Content-Encoding such as gzip, this results in a gzipped body
being returned to the client without the header specifying the content encoding
(hence resulting in the client receiving data it is unable to interpret).

The code that that contains the error was introduced to trunk in r1001884 to
fix PR45341, and the current PR (PR52120) was fixed in trunk in r1201331, so
any release that contains the r1001884 fix but not the r1201331 fix will suffer
from PR52120.

For the case where the request we are handling was in fact an if-modified-since
request, the old, pre-r1001884 code would have done the right thing, so this is
a regression in 2.2.18.  It might therefore be worth considering backporting
r1201331 to the 2.2.x branch.

r1001884 was backported to 2.2.x branch in r1068313 and 2.2.18 is the first
2.2.x tag that contains the fix (and therefore this regression).

2.4.x was branched from trunk r1200449, so already contained the r1001884 fix,
and r1201331 was merged into 2.4.x as r1201332 prior to 2.4.1 being tagged, so
no 2.4.x release suffers from this problem.

roy

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message