httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 53539] content type and character set are changing when the content served from disk_cache becomes 'stale'
Date Thu, 12 Jul 2012 13:53:49 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=53539

--- Comment #2 from Paul Beckett <p.beckett@uea.ac.uk> ---
(In reply to comment #1)
> Can you please check if r1132816 fixes your problem? The patch is at
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/cache/mod_cache.
> c?r1=1132816&r2=1132815&pathrev=1132816&view=patch

I have very little experience of using patch.... so sorry if this is my mistake
/ mis-understanding.

It looks to me like this 'change' is already in Apache 2.4.2, which I'm using,
the modules/cache/mod_cache lines look like:

            r->headers_out = cache->stale_handle->resp_hdrs;

            ap_set_content_type(r, apr_table_get(
                    cache->stale_handle->resp_hdrs, "Content-Type"));

            /* add a revalidation warning */
            warn_head = apr_table_get(r->err_headers_out, "Warning");
            if ((warn_head == NULL) || ((warn_head != NULL)

running the patch file, results in a some warnings:

patch /usr/local/httpd-2.4.2/modules/cache/mod_cache.c
/server-build/installers/apache_httpd/mod_cache.c.patch
patching file /usr/local/httpd-2.4.2/modules/cache/mod_cache.c
Reversed (or previously applied) patch detected!  Assume -R? [n]
Apply anyway? [n] y
Hunk #1 succeeded at 795 with fuzz 2 (offset -48 lines).


and a file that looks like:
            r->headers_out = cache->stale_handle->resp_hdrs;

            ap_set_content_type(r, apr_table_get(
                    cache->stale_handle->resp_hdrs, "Content-Type"));

            ap_set_content_type(r, apr_table_get(
                    cache->stale_handle->resp_hdrs, "Content-Type"));

            /* add a revalidation warning */
            warn_head = apr_table_get(r->err_headers_out, "Warning");


I haven't built or tried this, as I assume duplicating the ap_set_content_type
line isn't the intention.

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message