httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject [Bug 51696] Code clean up (remove a 1024 heap allocated buffer)
Date Tue, 10 Jul 2012 21:37:11 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=51696

--- Comment #2 from Christophe JAILLET <christophe.jaillet@wanadoo.fr> ---
Must be revisited due to some change in trunk.
Maybe should be closed now that the 1024 bytes buffer is gone.

Rearranging the code in 'make_cookie' could still be a win. It could avoid the
allocation of a buffer via apr_snprintf which is then apr_pstrdup'ed at the end
of the function.

This would save one of the 2 allocations which are strings build with: "%x.%"
APR_UINT64_T_HEX_FMT.

Would you like me to propose an updated patch ?

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message