httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 45456] mod_dbd don't allow more then one database pool
Date Fri, 06 Apr 2012 13:16:27 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=45456

--- Comment #9 from Igor Galić <i.galic@brainsware.org> 2012-04-06 13:16:27 UTC ---
We did a quick code-review in #httpd-dev today, and there's a couple of
questions

The thing that I noticed was:
https://issues.apache.org/bugzilla/attachment.cgi?id=25450&action=diff#a/modules/database/mod_dbd.c_sec19
on line line 1084 there's this mysterious declaration:

  dbd_pool_t *dbdpool = NULL;

We have no idea what that's doing there..

Furthermore you're modifying, or rather, breaking, the existing API of
ap_dbd_acquire_pool().
I'd rather we find a way to be backward compatible.

More comments this evening.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message