httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 51697] New: Code clean up (avoid allocating twice the same thing in proxy_util.c)
Date Sat, 20 Aug 2011 07:06:23 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=51697

             Bug #: 51697
           Summary: Code clean up (avoid allocating twice the same thing
                    in proxy_util.c)
           Product: Apache httpd-2
           Version: 2.3-HEAD
          Platform: PC
        OS/Version: Windows 2000
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Core
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: christophe.jaillet@wanadoo.fr
    Classification: Unclassified


Created attachment 27415
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27415
Proposed patch

Hi,

in 'ap_proxyerror' from 'modules/proxy/proxy_util.c', we call twice
'ap_escape_html' with the same parameters.

'ap_escape_html' allocates some memory in a pool, so by re-arranging the code,
we we can save one of this useless allocation.

Moreover, doing so is, IMO, more readable.

This patch is untested but seems trivial.


Best regards,
Christophe JAILLET

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message