Return-Path: X-Original-To: apmail-httpd-bugs-archive@www.apache.org Delivered-To: apmail-httpd-bugs-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 11AE46492 for ; Wed, 1 Jun 2011 13:22:41 +0000 (UTC) Received: (qmail 27662 invoked by uid 500); 1 Jun 2011 13:22:40 -0000 Delivered-To: apmail-httpd-bugs-archive@httpd.apache.org Received: (qmail 27619 invoked by uid 500); 1 Jun 2011 13:22:40 -0000 Mailing-List: contact bugs-help@httpd.apache.org; run by ezmlm Precedence: bulk List-Post: List-Help: List-Unsubscribe: Reply-To: "Apache HTTPD Bugs Notification List" List-Id: Delivered-To: mailing list bugs@httpd.apache.org Received: (qmail 27603 invoked by uid 99); 1 Jun 2011 13:22:39 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 13:22:39 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.115] (HELO eir.zones.apache.org) (140.211.11.115) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 01 Jun 2011 13:22:37 +0000 Received: by eir.zones.apache.org (Postfix, from userid 80) id A1FCD48ADA; Wed, 1 Jun 2011 13:21:56 +0000 (UTC) From: bugzilla@apache.org To: bugs@httpd.apache.org Subject: DO NOT REPLY [Bug 51285] [PATCH] rotatelogs: Add -p option to call arbitrary post-rotate program Date: Wed, 01 Jun 2011 13:21:56 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Apache httpd-2 X-Bugzilla-Component: support X-Bugzilla-Keywords: PatchAvailable X-Bugzilla-Severity: normal X-Bugzilla-Who: jorton@redhat.com X-Bugzilla-Status: NEW X-Bugzilla-Priority: P2 X-Bugzilla-Assigned-To: bugs@httpd.apache.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://issues.apache.org/bugzilla/ Auto-Submitted: auto-generated Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 X-Virus-Checked: Checked by ClamAV on apache.org https://issues.apache.org/bugzilla/show_bug.cgi?id=51285 --- Comment #4 from Joe Orton 2011-06-01 13:21:56 UTC --- Thanks for sending in the patch! I like the idea; I've had a requests for similar "do X post-rotate" functionality so there is some kind of general need here. A few comments: a) What's the purpose of the double-forking and thread support? apr_proc_create() will fork/exec internally, so why fork (/spawn thread) then call apr_proc_create()? b) Isn't the apr_tokenize_to_argv() usage going to split up any paths with spaces in? it should be simple enough to set up argv[] correctly without needing to flatten and reparse the string anyway. c) probably should set the cmdtype to APR_PROGRAM_ENV to pass through any env vars -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org For additional commands, e-mail: bugs-help@httpd.apache.org