httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 51398] New: Code clean-up (various
Date Mon, 20 Jun 2011 21:33:09 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=51398

             Bug #: 51398
           Summary: Code clean-up (various
           Product: Apache httpd-2
           Version: 2.3-HEAD
          Platform: PC
        OS/Version: Windows 2000
            Status: NEW
          Severity: normal
          Priority: P2
         Component: All
        AssignedTo: bugs@httpd.apache.org
        ReportedBy: christophe.jaillet@wanadoo.fr
    Classification: Unclassified


Created attachment 27181
  --> https://issues.apache.org/bugzilla/attachment.cgi?id=27181
Proposed patch

Hi,

here is a patch that makes a few cleans up.

modified files are :

  - server/util.c : use apr_pstrmemdup instead of apr_pstrdup in order to avoid
a call to strlen. Compute the length first and use it twice.

  - server/vhost.c : reorder code to do as above.
  - modules/proxy/proxy_util.c : same
  - modules/aaa/mod_authnz_ldap.c : more or less the same
  - modules/mappers/mod_rewrite.c : same
  - modules/dav/main/mod_dav.c : same
  - modules/dav/fs/repos.c : more or less the same

  - modules/proxy/mod_serf.c : use strcmp instead of strcasecmp when possible
                             : avoid a call to apr_pstrndup <-- PLEASE DOUBLE
CHECK THIS ONE TO SEE IF THERE IS NO SIDE EFFECT

  - modules/cluster/mod_heartmonitor.c : use 'ap_rputs' instead of 'ap_rprintf'


Before apply the patch, please at least double check 'modules/proxy/mod_serf.c'
to make sure that there is no side effect. The other ones should be ok as-is.

Hope this helps.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message