httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
Subject DO NOT REPLY [Bug 51285] [PATCH] rotatelogs: Add -p option to call arbitrary post-rotate program
Date Thu, 02 Jun 2011 06:39:31 GMT changed:

           What    |Removed                     |Added
                 CC|                            |

--- Comment #5 from 2011-06-02 06:39:31 UTC ---
Hi, Joe.

a) This started out as a separate thread (to avoid many processes in the pid
list) that calls the external program so that the thread would wait for the
program to finish, and catch any problems. I have no issues with changing this,
though. Would it make sense to simply fork the external program without looking
back, and let it handle its own errors? Its stderr is still directed to the
error log, presumably, so it's easy to catch problems anyway.

b) As far as I can see in the source, apr_tokenize_to_argv() does the right
thing with quoting and escaping. It requires users to put escaped spaces or
escaped quotes in the apache config, though. Some examples in the docs would
probably do the trick.

c) APR_PROGRAM was chosen since the env arg to apr_proc_create() is ignored if
the type is APR_PROGRAM_ENV. If we'd rather use apr_env_set() to set the vars,
then use APR_PROGRAM_ENV, that should take care of it.

Let me know what you think, and I'll make the changes.

Configure bugmail:
------- You are receiving this mail because: -------
You are the assignee for the bug.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message