httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 51285] [PATCH] rotatelogs: Add -p option to call arbitrary post-rotate program
Date Sun, 19 Jun 2011 19:43:24 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=51285

--- Comment #9 from sveniu@ifi.uio.no 2011-06-19 19:43:24 UTC ---
Thanks, this looks good! I've done a bit of testing, and have some notes:

1. The process management works well. I've tried:

   a) postrotate program taking longer (sleep) than the specified rotation
      interval. This of course builds up children, but works exactly as
      expected.

   b) Apache/rotatelogs exiting before postrotate program finishes: Child
      is adopted by init, and continues to run until it completes.

2. Some might be surprised by or dislike the defunct child processes in the
   process list. I don't mind them at all. A fix could be select/poll, which
   would also handle exit codes, etc, but I wouldn't say that's a blocker for
   committing.

3. The usage() output, the manpage and the xml program documentation should
   not refer to the env variables any more.

5. There's some stray trailing whitespace in your latest diff, lines 108 and
   122.

Would it be at all possible to also commit this to 2.2? My ultimate goal
is to have this included in Debian, hopefully in a Squeeze update (as opposed
to Wheezy, which could be years in the future).

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message