httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 49328] mod_filter mishandles contexts in subrequests, corrupt output with mod_deflate and mod_include
Date Tue, 08 Jun 2010 16:20:15 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=49328

--- Comment #5 from Joe Orton <jorton@redhat.com> 2010-06-08 12:20:11 EDT ---
Created an attachment (id=25550)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25550)
patch which fixes ap_invoke_filter_init

(Foreword: great analysis of both this and bug 17629, Alex - thanks)

1) I don't think it makes any sense for a filter to expect a second
"filter_init_func" invocation here merely because a subrequest has been created
and changed some independent part of the filter chain.

2) Although there is a vague caveat regarding this in the header, the code will
AFAICT re-run the "init" functions for any protocol/connection-level filters
for each request and each sub-request therein, which would be kind of insane if
it were the intended API.

So I would argue we should simply "clarify" the API description here and fix
the bug, rather than attempt to work around it.  Fixing the bug is fairly
simple, patch is attached and fixes the test case without causing any other
regressions in the test suite, for what that's worth.

I was hoping for an all-in-one solution for both this and bug 17629, by more
cleanly separating the subreq's filter chain from the main request_rec, as
mentioned in dev@ thread today, but couldn't get that working without
regressions.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message