httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 47476] Cannot renew stored session
Date Tue, 07 Jul 2009 05:32:16 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=47476





--- Comment #2 from Alexey Varlamov <alexey.v.varlamov@gmail.com>  2009-07-06 22:32:14
PST ---
Actually there are 2 interconnected issues. As I said, original code did not
reset expiry AND was dropping "Max-Age" value when updating session.
The first chunk of the patch only changes maxage setting logic, the expiry
handling is not changed:
< earlier the maxage was only set if a new session is created or a session
encountered which does not have expiry while it should per configuration (AFAIU
only possible if server gets re-configured adding MaxAge and user comes with
older cookie w/o expiry); and normally loaded sessions had maxage=0 (as maxage
is not included to session encoding)
--
> now maxage is set always when present in config.

So the first chunk is necessary preparation for the second one :) 
Otherwise, if loaded session is modified and saved but maxage is zero, it
should expire immediately.

As for the mess in functions, indeed they are declared to return int - don't
know why :)

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message