httpd-bugs mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bugzi...@apache.org
Subject DO NOT REPLY [Bug 45687] mod_charset_lite can drop error responses
Date Tue, 09 Sep 2008 13:11:47 GMT
https://issues.apache.org/bugzilla/show_bug.cgi?id=45687





--- Comment #7 from Dan Poirier <poirier@pobox.com>  2008-09-09 06:11:46 PST ---
Created an attachment (id=22546)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=22546)
Fix for send_bucket_downstream() to reuse a single temporary brigade

Ruediger Pluem commented on send_bucket_downstream():

  This is bad. Please store the brigade in the filter context and
  reuse it, by cleaning it. See also
  http://httpd.apache.org/docs/trunk/en/developer/output-filters.html#filtering
  The same error is in send_downstream and IMHO they can share the
  same brigade.

This patch fixes send_bucket_downstream().  It doesn't change
send_downstream(); what I'd like to do instead is just have
send_downstream() call send_bucket_downstream() and eliminate
some duplicated code.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org


Mime
View raw message